-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-16248] add notification refresh feature flag #12859
[PM-16248] add notification refresh feature flag #12859
Conversation
New Issues (12)Checkmarx found the following issues in this Pull Request
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12859 +/- ##
==========================================
- Coverage 34.28% 34.28% -0.01%
==========================================
Files 2935 2935
Lines 90229 90230 +1
Branches 16943 16943
==========================================
- Hits 30937 30931 -6
- Misses 56828 56835 +7
Partials 2464 2464 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing wrong with the flag itself - we've grouped Autofill owned flags together, however. Please rebase/update the branch against latest main
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16248
📔 Objective
Add notification-refresh feature flag
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes